fix(auth): do not use SSO JSON region as Kiro API host - #276
Open
BetterAndBetterII wants to merge 1 commit into
Open
fix(auth): do not use SSO JSON region as Kiro API host#276BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
Credentials-file `region` is for OIDC refresh only. Driving api_host from it sent traffic to unreachable regional endpoints (issue jwadow#81). Prefer a verified profile ARN, KIRO_API_REGION / api_region, or the default.
|
Thanks for the PR! 馃帀 Before merge, we need a one-time CLA confirmation. Full CLA text: Please reply once with: You need to write once, all further messages from me can be ignored. |
Author
|
I have read the CLA and I accept its terms |
|
@BetterAndBetterII could you give a try to this gateway: https://github.com/ankitcharolia/kiro-gateway It works quite well with All AI harness and actively being developed. The most important thing is that it is ACP compliant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
regionas the Kiro/Q API region (fixes BUG: Region override from credentials file causes connection failure when non-us-east-1 region is unreachable聽#81).KIRO_API_REGION/api_region, or the defaultus-east-1.regionremains used only for OIDC refresh.Test plan
uv run pytest tests/unit/test_auth_manager.py -q(129 passed)region=eu-west-1leaving API host at default