core/vm: refactor call gas calculation to avoid state lookups when not necessary #20
+196
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
force-pushed
the
call-gas-revamp
branch
2 times, most recently
from
f2c9da6 to
c524785
Compare
…ate access if the component of the call price which is independent from the state is not sufficient to cover the provided gas.
jwasinger
force-pushed
the
call-gas-revamp
branch
from
c524785 to
29f7cc5
Compare
jwasinger
changed the title
jwasinger
commented
Dec 8, 2025
| // - 63/64ths rule | ||
| old, err := oldCalculator(evm, contract, stack, mem, memorySize) | ||
| if err != nil { | ||
| return old, err |
Owner
Author
There was a problem hiding this comment.
returning old here in the case of an error doesn't have any special meaning. If the dynamic gas calculator returns an error, the returned gas is ignored in the interpreter loop here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.