releasing 1.5.0

k0shk0sh · Apr 2, 2017 · e3d37df · e3d37df
1 parent a5df952
commit e3d37df
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -27,8 +27,8 @@ android {
         applicationId "com.fastaccess.github"
         minSdkVersion 21
         targetSdkVersion 25
-        versionCode 141
-        versionName "1.4.1"
+        versionCode 150
+        versionName "1.5.0"
         signingConfig signingConfigs.signing
         buildConfigString "GITHUB_CLIENT_ID", (buildProperties.secrets['github_client_id'] | buildProperties.notThere['github_client_id']).string
         buildConfigString "GITHUB_SECRET", (buildProperties.secrets['github_secret'] | buildProperties.notThere['github_secret']).string

diff --git a/app/src/main/java/com/fastaccess/ui/modules/gists/gist/comments/GistCommentsPresenter.java b/app/src/main/java/com/fastaccess/ui/modules/gists/gist/comments/GistCommentsPresenter.java
@@ -113,12 +113,17 @@ class GistCommentsPresenter extends BasePresenter<GistCommentsMvp.View> implemen
     }
 
     @Override public void onItemClick(int position, View v, Comment item) {
-        if (item.getUser() != null) {
-            Login userModel = Login.getUser();
+        Login userModel = Login.getUser();
+        if (getView() == null) return;
+        if (v.getId() == R.id.delete) {
+            if (userModel != null && item.getUser().getLogin().equals(userModel.getLogin())) {
+                getView().onShowDeleteMsg(item.getId());
+            }
+        } else if (item.getId() == R.id.reply) {
+            if (getView() != null) getView().onTagUser(item.getUser());
+        } else if (item.getId() == R.id.edit) {
             if (userModel != null && item.getUser().getLogin().equals(userModel.getLogin())) {
                 if (getView() != null) getView().onEditComment(item);
-            } else {
-                if (getView() != null) getView().onTagUser(item.getUser());
             }
         }
     }

diff --git a/...java/com/fastaccess/ui/modules/repos/issues/issue/details/timeline/IssueTimelineView.java b/...java/com/fastaccess/ui/modules/repos/issues/issue/details/timeline/IssueTimelineView.java
@@ -194,9 +194,7 @@ public static IssueTimelineView newInstance(@NonNull Issue issueModel) {
     }
 
     @Override public void onToggle(int position, boolean isCollapsed) {
-        getSparseBooleanArray().clear();
         getSparseBooleanArray().put(position, isCollapsed);
-        adapter.notifyDataSetChanged();
     }
 
     @Override public boolean isCollapsed(int position) {

diff --git a/...s/repos/pull_requests/pull_request/details/timeline/timeline/PullRequestTimelineView.java b/...s/repos/pull_requests/pull_request/details/timeline/timeline/PullRequestTimelineView.java
@@ -117,9 +117,7 @@ public static PullRequestTimelineView newInstance(@NonNull PullRequest issueMode
     }
 
     @Override public void onToggle(int position, boolean isCollapsed) {
-        getSparseBooleanArray().clear();
         getSparseBooleanArray().put(position, isCollapsed);
-        adapter.notifyDataSetChanged();
     }
 
     @Override public boolean isCollapsed(int position) {