Skip to content

Add DCO Check workflow for pull requests #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Brijeshthummar02
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

Issue #112
What changes did you make? (Give an overview)

Added DCO workflow

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Brijeshthummar02 Brijeshthummar02 requested a review from a team as a code owner May 11, 2025 08:46
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels May 11, 2025
uses: actions/checkout@v2

- name: Check DCO
uses: wip/apply-dco@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this? http://github.com/wip/apply-dco doesn't resolve to anything

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried to add DCO for everyone as mentioned in issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Haarolean without PR it can be done by repo admins, or person having permissions i can set it but i don't have right of member for repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Brijeshthummar02 don't you mind to share, which issue are you referring to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@germanosin #112 i have mentioned in PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Haarolean without PR it can be done by repo admins, or person having permissions i can set it but i don't have right of member for repo.

@Brijeshthummar02 that's right, #112 mentions an app, bur you're raising a PR with a workflow. The aforementioned app doesn't need a workflow. Furthermore, it seems wip/dco action doesn't exist, and the account wip on github doesn't have such a repo. Where did you pull this action from? Is this AI-generated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes my bad, i was trying to take help about how it can be done without permissions.
We can close this PR.

You can directly add and configure it from https://github.com/apps/dco i have done i my fork it worked
Screenshot 2025-05-12 152214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants