-
-
Notifications
You must be signed in to change notification settings - Fork 140
Add DCO Check workflow for pull requests #1067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/dco-check.yml
Outdated
uses: actions/checkout@v2 | ||
|
||
- name: Check DCO | ||
uses: wip/apply-dco@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this? http://github.com/wip/apply-dco
doesn't resolve to anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i tried to add DCO for everyone as mentioned in issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Haarolean without PR it can be done by repo admins, or person having permissions i can set it but i don't have right of member for repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Brijeshthummar02 don't you mind to share, which issue are you referring to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@germanosin #112 i have mentioned in PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Haarolean without PR it can be done by repo admins, or person having permissions i can set it but i don't have right of member for repo.
@Brijeshthummar02 that's right, #112 mentions an app, bur you're raising a PR with a workflow. The aforementioned app doesn't need a workflow. Furthermore, it seems wip/dco action doesn't exist, and the account wip
on github doesn't have such a repo. Where did you pull this action from? Is this AI-generated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes my bad, i was trying to take help about how it can be done without permissions.
We can close this PR.
You can directly add and configure it from https://github.com/apps/dco i have done i my fork it worked
Issue #112
What changes did you make? (Give an overview)
Added DCO workflow
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)