feat(helm): add podLabels for the chart's pods - #48
Open
QuentinBisson wants to merge 1 commit into
Open
QuentinBisson wants to merge 1 commit into
QuentinBisson wants to merge 1 commit into
Conversation
This was referenced Sep 23, 2026
EItanya
force-pushed
the
main
branch
2 times, most recently
from
September 23, 2026 18:41
0401cc1 to
08c930d
Compare
A multi-tenant telemetry collector commonly takes a pod's tenant from a pod label, the one signal a headerless OTLP export carries. The chart sets only its own `app` label on every pod and offers no way to add one. `podLabels` is added to every long-running pod template, next to `app`, which it cannot replace: `app` is the selector of every workload, so the render fails when podLabels sets it. The rustfs-bucket-init Job is left out, because a Job's pod template is immutable and a label change would fail the upgrade. The default render is unchanged, so manifests/ate-install/ stays as is. Signed-off-by: QuentinBisson <quentin@giantswarm.io>
QuentinBisson
force-pushed
the
feat/chart-pod-labels
branch
from
September 24, 2026 08:54
095ae30 to
a92dc6b
Compare
QuentinBisson
added a commit
to giantswarm/substrate
that referenced
this pull request
Sep 24, 2026
QuentinBisson
marked this pull request as ready for review
September 24, 2026 08:59
QuentinBisson
added a commit
to giantswarm/substrate
that referenced
this pull request
Sep 24, 2026
QuentinBisson
added a commit
to giantswarm/substrate
that referenced
this pull request
Sep 24, 2026
* feat(helm): add podLabels for the chart's pods A multi-tenant telemetry collector commonly takes a pod's tenant from a pod label, the one signal a headerless OTLP export carries. The chart sets only its own `app` label on every pod and offers no way to add one. `podLabels` is added to every long-running pod template, next to `app`, which it cannot replace: `app` is the selector of every workload, so the render fails when podLabels sets it. The rustfs-bucket-init Job is left out, because a Job's pod template is immutable and a label change would fail the upgrade. The default render is unchanged, so manifests/ate-install/ stays as is. Signed-off-by: QuentinBisson <quentin@giantswarm.io> (cherry picked from commit 095ae30) * docs(fork): ledger row, podLabels on the chart's pods (kagent-dev#48) --------- Signed-off-by: QuentinBisson <quentin@giantswarm.io>
QuentinBisson
added a commit
to giantswarm/substrate
that referenced
this pull request
Sep 24, 2026
* feat(helm): add podLabels for the chart's pods A multi-tenant telemetry collector commonly takes a pod's tenant from a pod label, the one signal a headerless OTLP export carries. The chart sets only its own `app` label on every pod and offers no way to add one. `podLabels` is added to every long-running pod template, next to `app`, which it cannot replace: `app` is the selector of every workload, so the render fails when podLabels sets it. The rustfs-bucket-init Job is left out, because a Job's pod template is immutable and a label change would fail the upgrade. The default render is unchanged, so manifests/ate-install/ stays as is. Signed-off-by: QuentinBisson <quentin@giantswarm.io> (cherry picked from commit 095ae30) * docs(fork): ledger row, podLabels on the chart's pods (kagent-dev#48) --------- Signed-off-by: QuentinBisson <quentin@giantswarm.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
podLabels(empty by default) to every long-running pod template, next to the chart'sapplabel. It lets an installation set, for example, the label a multi-tenant telemetry collector uses to find the tenant of an OTLP export.appis the selector label, so the render fails ifpodLabelssets it. Therustfs-bucket-initJob does not get the labels, because a Job's pod template is immutable. The default render does not change (make verify-helm-templatepasses).