Skip to content

Midi Sync Wobble#4

Open
iandoesallthethings wants to merge 14 commits into
kaiakairos:masterfrom
iandoesallthethings:feature/midi-synced-wobble
Open

Midi Sync Wobble#4
iandoesallthethings wants to merge 14 commits into
kaiakairos:masterfrom
iandoesallthethings:feature/midi-synced-wobble

Conversation

@iandoesallthethings
Copy link
Copy Markdown

@iandoesallthethings iandoesallthethings commented May 5, 2024

Definitely

  • Add midi clock sync option to the wobble feature
  • Toggle between midi and free wobble in menu
  • Select midi device in settings

Maybe (Might split these out into a separate PR)

  • Use midi notes for toggles and costume changes 🤞
  • Momentary toggle (i.e. hold to show for momentary expressions)

Note: I used the autoformatter in godot-tools for vscode, which accounts for a lot of the changes in main. I'm happy to roll back the autoformatting if you'd prefer I leave it alone!

Update: I went ahead and rolled back the autoformatting so the diff isn't such a mess. The one exception is the default save file in autoload lol. not doing that by hand.

@iandoesallthethings iandoesallthethings marked this pull request as ready for review May 7, 2024 03:54
@iandoesallthethings iandoesallthethings changed the title [feature] Midi Wobble Midi Sync Wobble Oct 20, 2024
@iandoesallthethings
Copy link
Copy Markdown
Author

Hm. Considering adding a sample rate selector. Sometimes juggling audio inputs is messy if you're trying to record the same input that's feeding pngtuber.

Comment thread autoload/saving.gd
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding useMidiWobble to the default sprites for posterity.

Comment thread main_scenes/main.gd
var size = get_viewport().get_visible_rect().size

var windowLength = 1250 #1187
var windowLength = 1275 #1187
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of extra space for the midi options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant