Audio delay fix & more#8
Open
k0ffinz wants to merge 3 commits into
Open
Conversation
found out channel auto-disabling might be the issue. tested it myself and it seems to fix it without the need to recreate the mic (which leads to even more problems like global mic glitches and even app crashing, and ill address them in the next commit)
and rewrite how mic is re/initialized
didnt replace right away in case some people wont like it or it has some issues uses some different way of getting active mic volume (directly from the bus instead of its analyzer effect) which also makes it smoother also realigned everything in the settings panel to make some space for another checkmark
|
guh |
1 similar comment
|
guh |
Raltyro
approved these changes
Jul 3, 2024
|
What the
…On Wed, Jul 3, 2024, 12:42 Ralty ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#8 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BJTEYGRHT5DWDE6PP6CCKNDZKN6K3AVCNFSM6AAAAABKINELEOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNJVGQZDIMBSHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Hey mate, just wanted to say thanks for your pull request, I've implemented it over on my fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I've got some issues like my mic getting glitchy globally, mic sound getting delayed and even app crashing (related to the first issue).
The first 2 commits should hopefully fix those problems.
Glitching mic issue was because it was reinitialized a lot and godot doesn't dispose old instances of it, the app was crashing for the same reason, and audio delay is probably because of the bus auto-disabling feature so I simply disabled it.
The 3rd commit is just there in case people like it.
Test it to make sure the issues got resolved.