Skip to content

fix: close the mobile menu when navigating via the site-name link#102

Merged
kaiiiichen merged 1 commit into
mainfrom
fix/mobile-menu-close-on-nav
Jul 10, 2026
Merged

fix: close the mobile menu when navigating via the site-name link#102
kaiiiichen merged 1 commit into
mainfrom
fix/mobile-menu-close-on-nav

Conversation

@kaiiiichen

Copy link
Copy Markdown
Owner

Summary

Re-lands the second half of #100 (that PR was merged before this commit was pushed to its branch):

  • The mobile dropdown links closed the menu on tap, but the top-left "Kai T. Chen" brand link navigated home with the menu left open — it now closes on click
  • The menu also resets whenever the pathname changes (render-time adjustment), so back/forward navigation collapses it too

Test plan

  • npm run lint / npm run typecheck / npm run test (23) / npm run build
  • Previously browser-verified at mobile viewport: menu open on /about → tap brand → lands on / with menu collapsed (aria-expanded=false)

🤖 Generated with Claude Code

The dropdown links closed the menu on tap but the top-left brand link
did not. Close on brand click, and also reset the menu whenever the
pathname changes (render-time adjustment) so back/forward navigation
collapses it too.

Co-authored-by: Claude <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
kaichen.dev Ready Ready Preview, Comment Jul 10, 2026 9:18am

@kaiiiichen kaiiiichen merged commit 5fd2857 into main Jul 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant