Use issuer SKI for AKI when transferring CSR extensions.#763
Merged
kaikramer merged 1 commit intokaikramer:mainfrom Mar 5, 2026
Merged
Use issuer SKI for AKI when transferring CSR extensions.#763kaikramer merged 1 commit intokaikramer:mainfrom
kaikramer merged 1 commit intokaikramer:mainfrom
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem where KSE will use the wrong authority key identifier when transferring extensions during CSR signing.
GnuTLS certtool uses the SHA-1 hash over the SPKI for the AKI and SKI extensions. This deviates from RFC 5280 method 1, which is the default method used by KSE.
KSE was updated to use the issuer SKI when applying the standard extension template in Add Certificates (see #560), but KSE continued to use RFC 5280 when transferring the CSR extensions to the newly signed certificate. If a user chooses to transfer the extensions rather than applying the standard template when signing the CSR, the cert chain will be invalid.
After this PR is merged, KSE will now use the issuer SKI for the issued certificate's AKI when: