Open key stores in an existing instance of KSE.#767
Open
jonwltn wants to merge 1 commit intokaikramer:mainfrom
Open
Open key stores in an existing instance of KSE.#767jonwltn wants to merge 1 commit intokaikramer:mainfrom
jonwltn wants to merge 1 commit intokaikramer:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #241 by opening key store files using an existing instance. If an existing instance does not exist, then it loads normally.
This PR reorganizes the auto reload settings and combines them with a new setting for opening files in an existing instance:

The first instance of KSE will open a unix domain socket (kse-ipc.sock) in the users temporary directory. This socket is always opened regardless of the configuration setting. Subsequent instances of KSE when opened with a list of files will attempt to send the list to an existing instance for opening and immediately close. If the existing instance cannot be contacted, then KSE loads and opens the files.
If the user preference setting is disabled, KSE will not check for an existing instance and will open the key stores using a new instance.
Limitations
Finally, this feature works on macOS, but it won't be used since MacOsIntegration manages the opening of files.