Repository navigation
fix(mind): confirm sheet and payment agree; prepare 0.9.0 - #122
Merged
Merged
Conversation
- Pay exactly the destination the sheet showed; an invoice's own amount wins and a different amount from the model is refused - Refuse a Lightning-address invoice for a different amount than approved - Flashnet swaps: floor at the shown 1% tolerance, shown as "At least" - Agent wallet confirm shows the budget the limits leave - Readable assistant errors instead of raw messages - Drop the get_swap_quote stub tool - Version 0.9.0 and changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before 0.9, the assistant's money-moving path had gaps where the confirm sheet could show one thing and the payment do another. This closes them, makes a few assistant details clearer, and bumps the version to 0.9.0 with the changelog.
What changes for the user
get_swap_quotestub tool is removed (it only pointed at the Swap screen).How it works
previewSendPaymentpins what the sheet resolved for 5 minutes;send_paymentuses it instead of resolving again.reconcileInvoiceAmountis used by the sheet and the handler, so both agree on the amount.FLASHNET_MIN_RECEIVE_FRACTIONties the swap floor to the price tolerance already used for re-approval.services/aiErrors.tsmaps known failures and hides technical ones.Release prep
package.jsonandapp.jsongo to 0.9.0. The CHANGELOG moves Unreleased under 0.9.0 and adds the merged work that was missing from it (RGB on this phone, Prismo, Agent wallet) and these fixes. Taggingv0.9.0is left for after merge.Testing
Full jest suite (215 suites, 1675 tests) and
tsc --noEmitpass. New tests cover contact-address change between sheet and payment, amount mismatch, LNURL invoice mismatch, the Flashnet floor row, budget row and error messages. Not tried on a device.