fix: kalibr_model_used on response + re-resolve tenant_id in singleton#190
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bug fixes found during simulation testing:
kalibr_model_used not set on response -- completion() set kalibr_trace_id, kalibr_healed, kalibr_heal_count, kalibr_models_tried but never kalibr_model_used. Fixed at both the heal path (uses used_model) and the normal path (uses candidate_model).
Singleton tenant_id empty if env var set after construction -- _get_intelligence_client() creates the singleton once. If KALIBR_TENANT_ID was not in env at first call, tenant_id was empty string, causing 422 on every report_outcome call. Fixed: re-resolves on each call if tenant_id is empty.