Conversation
🚀 Preview deployed
|
|
governance: PASS @ d2bf9b9 content:28d8176a739b — no contradiction, no weakening Scope
The gate half — does this quietly weaken a guard
Read by hand alongside it, because a removal PR is the shape where a guard goes quiet rather than
No weakening found. The corpus half — does this contradict standing lawNo decision record is added, so there is no subject the ranking sweep exists to rank; the The questions this diff answers, asked against the corpus:
No contradiction with standing law found. Verdict PASS. Named, and routed rather than judged hereThree of the seven record edits go past removing a mention and restate the record's own grounds.
The founder's ruling on #9558 authorises "mentions edited out" with no record deleted, and these Bound to the head read above; nothing outside the verbs' own reads was treated as authority. |
|
review-code: FAIL @ d2bf9b9 content:28d8176a739b — three stale-text residues in live code Judged at The short versionThe removal itself is excellent, and I could not break it where it was most likely to break. The What I proved, and howCI at head: Editing applied migrations (the highest-risk half) — clean, and here is the proof.
Nothing left behind still reaches the removed product. Shared code kept on purpose is kept. No production step hides in the diff. No No scope creep. 47 deletions + 69 modifications + 1 rename = 117, and every one of the 69
Targeted unit run at head: 11 files, 145 tests, all passing — Findings — why this is a FAIL1.
The rewritten 2. 3. Named, not blocking
Deviations
Verdict-written: 2026-09-21T03:17:49Z |
|
review-doc: FAIL @ d2bf9b9 content:28d8176a739b — ADR 0179 left self-contradictory by its own edit Judged at What holdsThe doc edits are surgical and, with one exception, correct. Every modified doc path is named Guards, all green at this head.
AC14 holds. No AC15 holds. The AC16 holds, on the evidence it names. The marked criterion points at the founder's answer to Editorial craft ( Findings — why this is a FAIL1.
"Four" counted the three named flags plus The same edit also weakens the sentence's form: "That is exactly: nav-shaping flags" applies a 2.
Named for the founder, not judged hereThree of the seven record edits go past "mentions edited out" and restate the record's own grounds.
The founder's ruling on #9558 authorises editing mentions out with no record deleted, and the repo's
Nits, non-blocking
Deviations
Verdict-written: 2026-09-21T03:18:35Z |
Part of #9558. This is PR 2, after PR 1 and the operator's adopt confirmation.
Removes the retired publishing product in one change: routes, pages, worker services, three flags, schema, catalogs, fixtures, and documentation. The working tree and tracked filenames contain zero case-insensitive
mecmuamatches. The shared composer stays in use by Atölye; shell boot keeps an empty flag manifest and its typedusermember.The two previously renamed migrations are now zero-byte no-ops. All four Drizzle snapshots drop only the retired tables' entries, and the migration guard generated the second baseline. Every other migration stays byte-identical and in place. Every decision record stays, with unchanged frontmatter.
Pending outside this PR's local validation: the seven kept issues still need the operator's scope edits; integration and browser execution need the normal preview/CI run. Those acceptance criteria are not claimed complete below. No deployment, D1 command, dashboard change, issue closure, or milestone closure was performed by this work.
Production follow-up — operator only
After this PR lands, the operator may run
DROP TABLE mecmua_post; DROP TABLE mecmua_subscription;outside this PR. That drop is destructive. The issue's recorded counts aremecmua_post= 3 rows andmecmua_subscription= 0 rows. The driver confirmed export outside the repo. This PR adds no drop migration and does not perform the drop.Acceptance criteria — issue order
0025_retired_table_a.sqland0026_retired_table_b.sql, retaining both numeric prefixes and original SQL bytes.pnpm --filter @kampus/migrations-guard baseline; its two hashes retained their original values.0025_retired_table_a.sqland0026_retired_table_b.sql; production was not queried by this work.CLOSED / NOT_PLANNEDand a comment pointing to 9558 on 2506, 2526, 3106, 3107, 3115, 3116, 3122, 7870, and 7871.git diff --name-status --find-renamesconfirms 47 deletions and one rename.account.locale.test.tsx, removed only the retired catalog assertions, retained both account tests; the client suite passes.App.tsx, routes, fate registry/views/layers/errors, fanned mutations, catalogs, wire codes,flags/keys.ts,flagship/resources.ts, andalchemy.run.tsare clean.SHELL_FLAG_KEYSis[] as const; flag declarations and factories are removed through source. Typecheck and the zero-match scan pass.schema.tsno longer declares either table;Pasaport.tskeeps the mute and visibility cleanup. The integration test retains those seeds and assertions.wrote baseline for 38 migration(s); migration guard passes..decisions/file is deleted. A byte comparison of every record's frontmatter against the branch base found no change; decisions-index validates all 390 records.ROADMAP.md; roadmap-guard passes I1–I5 with three arc rows.ROADMAP.md:7keeps the existing sözlük/pano glosses;DEVELOPMENT.md:3names the same two products. Authority: founder wording approval.user.shell-boot-parity.unit.test.tscovers the sharedmeresolver's fresh identity, trusted standing, serialization, and signed-out null.29-edge-shell-boot-journey.spec.tsnow checks the user pill's geometry, signed-in first paint, and absent-payload fallback. Unit tests pass; Playwright lists all three tests. Browser execution remains pending.git grep -i mecmuaproduces no output, exit 1. Main's post-merge verification remains with the operator; this PR is not merged.git ls-files | grep -i mecmuaproduces no output, exit 1, after staging the deletions and rename.brandNouns.unit.test.tsassertions pass: nonempty coverage, equal catalog key sets, identical brand nouns.catalog-split.unit.test.tsassertions pass, including a real build's separate English chunk.pnpm --filter @kampus/web buildpasses (built in 8.20s).Validation results
Run in this branch's isolated checkout, using package-owned scripts. The final targeted unit run covers the boot changes made while the full suite was running.
LAW-SOURCE: manifest-prose (
design-system-manifest.md). The nav retains the sözlük/pano destinations; rendered preview evidence is pending. Governance and code-owner review remain separate PR gates.Deviations
build/branch. Did: used the user's requiredumut/branch and direct git/gh for commit, push and PR creation, with normal hooks. Why: the explicit task instruction takes precedence over the helper's branch convention. Disposition: package-owned validation and the claim check were retained; no merge or auto-merge requested.