Skip to content

Add Synthetic Sound theme#2

Merged
Schneegans merged 10 commits into
kando-menu:mainfrom
lcgjapan:main
Jul 19, 2025
Merged

Add Synthetic Sound theme#2
Schneegans merged 10 commits into
kando-menu:mainfrom
lcgjapan:main

Conversation

@lcgjapan
Copy link
Copy Markdown
Contributor

@lcgjapan lcgjapan commented Jul 9, 2025

Synthetic Sound Theme

Description

A futuristic synthetic sound theme with carefully balanced audio effects.

Features

  • ✨ Synthetic electronic sounds
  • 🎚️ Balanced volume levels
  • 🎵 Pitch variation for hover effects
  • 🔊 8 different sound effects for all menu interactions

Authors

Rena and LCG

License

CC0-1.0

lcgjapan added 4 commits July 10, 2025 00:11
Create theme.json5 file for Synthetic Sound theme.

This file contains the configuration for the Synthetic Sound theme,
including all 8 sound effects with carefully balanced volume levels
and pitch variations for enhanced user experience.

Features:
- Futuristic synthetic sounds
- Dynamic pitch variation for hover effects
- Balanced volume levels (0.3-0.8)
- Complete sound coverage for all menu interactions
Copy link
Copy Markdown
Contributor

@yar2000T yar2000T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @lcgjapan! Do these sounds have a license? If it has a license, you need to obtain it and specify it in REUSE.toml. You can just copy the licenses and paste them here for every sound, and I will help you set it up properly

@lcgjapan
Copy link
Copy Markdown
Contributor Author

lcgjapan commented Jul 9, 2025

你好@lcgjapan!这些声音有许可证吗?如果有许可证,您需要获取许可证并在 中指定REUSE.toml。您可以直接复制每个声音的许可证并将其粘贴到这里,我会帮助您正确设置。

Hello @yar2000T! Thank you for the review.

The sound files were sourced from ZapSplat.com. Since I downloaded and used multiple sounds over time, I cannot identify the specific original files for each of our 8 sound effects.

To ensure compliance, I would like to credit ZapSplat for all sounds under their Standard License terms, which requires attribution.

Could you help me set up the REUSE.toml to properly credit "ZapSplat" as the source for all sound files? I believe this covers the safest approach for compliance.

The 8 sound files are:

  • item_hover.mp3
  • item_select.mp3
  • menu_close.mp3
  • menu_open.mp3
  • parent_hover.mp3
  • parent_select.mp3
  • submenu_hover.mp3
  • submenu_open.mp3

Thank you for your guidance!

@lcgjapan
Copy link
Copy Markdown
Contributor Author

lcgjapan commented Jul 9, 2025

你好@lcgjapan这些声音有许可证吗?如果有许可证,您需要获取许可证并在中指定REUSE.toml。您可以直接将每个复制声音的许可证粘贴到这里,我会帮助您正确设置。

Additionally, I should mention that each of our 8 sound files was created by trimming/editing portions of the original ZapSplat sounds, not using them in their entirety. The sounds were shortened and modified to fit the specific timing and requirements for our theme.

Does this affect the licensing requirements in any way?

@yar2000T
Copy link
Copy Markdown
Contributor

yar2000T commented Jul 9, 2025

你好@lcgjapan这些声音有许可证吗?如果有许可证,您需要获取许可证并在中指定REUSE.toml。您可以直接将每个复制声音的许可证粘贴到这里,我会帮助您正确设置。

Additionally, I should mention that each of our 8 sound files was created by trimming/editing portions of the original ZapSplat sounds, not using them in their entirety. The sounds were shortened and modified to fit the specific timing and requirements for our theme.

Does this affect the licensing requirements in any way?

No, trimming or editing ZapSplat sounds to fit your sound theme does not remove the attribution requirement under the ZapSplat Standard License. You are still required to credit them.

Copy link
Copy Markdown
Contributor

@yar2000T yar2000T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a file with the name: LicenseRef-ZapSplat-Standard.txt in the LICENSES folder with the text:

ZapSplat Standard License
https://www.zapsplat.com/license-type/standard-license/

Sound effects obtained from https://www.zapsplat.com
These sounds are licensed under the ZapSplat Standard License.
Attribution is required unless a Gold account is held.

The sounds must be embedded in a production and not redistributed as-is.
ZapSplat retains full copyright.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paste this text into your REUSE.toml:

# SPDX-FileCopyrightText: 2025 Rena and LCG
# SPDX-License-Identifier: CC0-1.0

version = 1

[[annotations]]
path = "**"
precedence = "closest"
SPDX-FileCopyrightText = "2025 Rena and LCG"
SPDX-License-Identifier = "CC0-1.0"

[licenses."ZapSplat-Standard"]
file = "LICENSES/LicenseRef-ZapSplat-Standard.txt"
spdx-id = "LicenseRef-ZapSplat-Standard"

[[files]]
path = "item_hover.mp3"
copyright = "ZapSplat"
license = "ZapSplat-Standard"

[[files]]
path = "item_select.mp3"
copyright = "ZapSplat"
license = "ZapSplat-Standard"

[[files]]
path = "menu_close.mp3"
copyright = "ZapSplat"
license = "ZapSplat-Standard"

[[files]]
path = "menu_open.mp3"
copyright = "ZapSplat"
license = "ZapSplat-Standard"

[[files]]
path = "parent_hover.mp3"
copyright = "ZapSplat"
license = "ZapSplat-Standard"

[[files]]
path = "parent_select.mp3"
copyright = "ZapSplat"
license = "ZapSplat-Standard"

[[files]]
path = "submenu_hover.mp3"
copyright = "ZapSplat"
license = "ZapSplat-Standard"

[[files]]
path = "submenu_open.mp3"
copyright = "ZapSplat"
license = "ZapSplat-Standard"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yar2000T,

Thank you so much for the detailed feedback and guidance! I really appreciate your help with the licensing requirements.

I have now made the following updates:

✅ Created LICENSES/LicenseRef-ZapSplat-Standard.txt with the ZapSplat Standard License text
✅ Updated REUSE.toml with the proper licensing configuration for all sound files
✅ Added proper attribution for ZapSplat as the copyright holder

All the changes have been committed to this pull request. The licensing should now be compliant with both the ZapSplat Standard License and the project's REUSE requirements.

Thank you again for taking the time to review and provide such helpful guidance! 🙏

Best regards,
LCG

@Schneegans
Copy link
Copy Markdown
Contributor

This is a pretty awesome theme! Thank you very much! Two things in addition to what @yar2000T mentioned above:

  • Can you add a link to the bottom of the main README file? There the two other themes are linked and you could add yours to the list.
  • The preview.jpg is not required. You can remove it.

lcgjapan added 4 commits July 14, 2025 23:13
Update REUSE.toml for ZapSplat license compliance
Add Synthetic Sound theme to README
@lcgjapan
Copy link
Copy Markdown
Contributor Author

这主题太棒了!非常感谢!除了@yar2000T上面提到:

  • 你能在主 README 文件底部添加一个链接吗?那里有另外两个主题的链接,你可以把你的主题添加到列表中。
  • preview.jpg 不是必需的。您可以将其删除。
    Hi @Schneegans,

Thank you so much for the positive feedback! I'm thrilled that you like the theme! 🎉

I have completed both remaining items:

✅ Added the theme to the main README.md file alongside the other themes
✅ Removed the preview.jpg file (didn't realize sound themes don't need previews)

All changes have been committed to this pull request. The theme should now meet all the requirements for inclusion in the sound themes repository.

Thank you for taking the time to review this submission and for all your wonderful work on Kando! The project is truly amazing.

Best regards,
LCG

Copy link
Copy Markdown
Contributor

@yar2000T yar2000T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@Schneegans
Copy link
Copy Markdown
Contributor

Thanks a lot for working on this! However, I think the licensing files still do not look fully right. Basically, each REUSE.toml should have an entry for each file in the same directory. You seem to have put the information for your sound files in the root REUSE.toml, but it has to be in main/themes/Synthetic sound. Could you move it in there?

Thank you so much!

@lcgjapan
Copy link
Copy Markdown
Contributor Author

Thanks a lot for working on this! However, I think the licensing files still do not look fully right. Basically, each REUSE.toml should have an entry for each file in the same directory. You seem to have put the information for your sound files in the root REUSE.toml, but it has to be in main/themes/Synthetic sound. Could you move it in there?

Thank you so much!

Hi @Schneegans,

Thank you for the clarification! You're absolutely right about the REUSE.toml structure.

I have now fixed the licensing organization:

✅ Restored the root REUSE.toml to its original state (managing only repository-wide files like banner.png)
✅ Created a new REUSE.toml file specifically in the themes/Synthetic sound/ directory to manage the sound files
✅ Moved all the ZapSplat licensing information to the theme-specific REUSE.toml

Now each theme has its own independent copyright management, which is much cleaner and follows the proper structure.

Thank you for your patience and guidance in getting this right! I really appreciate you taking the time to help me understand the correct REUSE organization.

Best regards,
LCG

@Schneegans
Copy link
Copy Markdown
Contributor

I think there is still some issue with the format. I'll just fix this, I think that's faster than chatting about it here 😄 Thank you so much for the contribution!

@Schneegans Schneegans merged commit 491b087 into kando-menu:main Jul 19, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants