Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realtime updates #110

Open
wants to merge 119 commits into
base: develop
Choose a base branch
from
Open

Realtime updates #110

wants to merge 119 commits into from

Conversation

alextud
Copy link

@alextud alextud commented Feb 9, 2018

We have created a netfox_mac app which can connect to all apps (iOS or mac) that are running in local network using bonjour discovery mechanism.

Basically an iOS app that wants to expose it's network data to other mac app for inspection should activate bonjour service using:
NFX.sharedInstance().startServer()

After that netfox_mac app can connect using the same UI as in the mac app with some teaks.

We want to merge back all changes into netfox repo after code and most of the new features are stable.

How that's sound, is it doable ?
Thanks

screenshot 2018-02-09 16 51 12
screenshot 2018-02-09 16 51 30

Alexandru Tudose and others added 30 commits October 27, 2017 15:23
…ests, added a manager of this structure, similar to the existing one for http requests
@alextud
Copy link
Author

alextud commented Mar 13, 2018

@Janglinator There is an issue with continuous integration, can you look into that. On our side we need to update Readme page. Will move at the end description and images about netfox for mac integration.

@Janglinator
Copy link
Contributor

I added a pull request to @alextud's pull request repo (pull-request-ception!), so just waiting for him to get that pulled in, then CI should pass. The branch is already passing.

Moved netfox description at the end of Readme. Mention tapptitude .
@alextud
Copy link
Author

alextud commented Mar 15, 2018

@Janglinator I've move Readme notes about netfox_mac app in the second part of file. Also I've added a short thank you mention for tapptitude team. Thanks

@alextud
Copy link
Author

alextud commented Jul 24, 2018

Hi, any news on this pull request being accepted ?

@Janglinator
Copy link
Contributor

Let's get this merged in! Would you be able to patch up the merge conflicts?

@Janglinator
Copy link
Contributor

@alextud The build failed, but that's because your commit doesn't support Swift 3.2.

I brought this up in PR #140, we might just drop Swift 3.2 support. So just wait for a response from @kasketis to see if you even need to make any changes.

@felipeflorencio
Copy link
Contributor

@Janglinator as we already need to start support to Swift 4.2, "soon" 5.0 I thing that would not be bad drop support for 3.2, even because to always maintain and try to follow best that swift can support, unfortunately today for swift environment we do need to migrate as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants