fix: remove 'ValueError' from return union for 'wrap_constant'#769
Closed
vkcku wants to merge 1 commit intokayak:masterfrom
vkcku:wrap-constant-typing
Closed
fix: remove 'ValueError' from return union for 'wrap_constant'#769vkcku wants to merge 1 commit intokayak:masterfrom vkcku:wrap-constant-typing
vkcku wants to merge 1 commit intokayak:masterfrom
vkcku:wrap-constant-typing
Conversation
williambdean
approved these changes
Feb 21, 2024
Contributor
williambdean
left a comment
williambdean
left a comment
There was a problem hiding this comment.
Seems good! Any thoughts @AzisK ?
Contributor
|
Hey, I am sorry I never replied. We can merge it if you still wish |
Author
Sorry! I hadn't realized deleting my fork would close the PR. Yeah merging it would be great :) I can make another PR if you want. |
Contributor
|
Yes, you can make another one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
ValueErrorfrom the union in the return type ofTerm.wrap_constant.