Repository navigation
Bump Go to 1.26.1 and golangci-lint to 2.11.3 - #499
Merged
Merged
Conversation
ntnn
reviewed
Mar 20, 2026
| // go-build-version 1.25.4 | ||
| go 1.24.0 | ||
| // go-build-version 1.25.8 | ||
| go 1.25.8 |
Member
There was a problem hiding this comment.
The minimum should always be the .0, or?
Member
Author
There was a problem hiding this comment.
I think it should be equal, this is used for go version checking script to ensure all versions are consistent
Member
There was a problem hiding this comment.
The go-build-version should be the version we build with, the go version itself should just be the major version, we do it in kcp the same way (unless there's a security issue that requires us to use a later go version)
Member
Author
There was a problem hiding this comment.
I see, then lets do it the same way as in the kcp
cnvergence
changed the title
ntnn
reviewed
Mar 30, 2026
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
ntnn
approved these changes
Mar 30, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR will update Go version to 1.26.1, fixing recent CVEs.
We also need to bump golangci-lint, as build version was 1.24 in the previous golangci-lint version, this required fixing linter issues across our codebase.
What Type of PR Is This?
Related Issue(s)
Fixes #
Release Notes