[WIP] UPSTREAM: <carry>: Keep system:cluster:* groups #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nelo-T. Wallus <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ntnn
changed the title
ntnn
commented
Aug 12, 2025
Comment on lines
+118
to
126
| // Filter groups to only include system:authenticated | ||
| // and system:cluster:* | ||
| for _, g := range u.GetGroups() { | ||
| if g == user.AllAuthenticated { | ||
| rewritten.Groups = []string{user.AllAuthenticated} | ||
| break | ||
| rewritten.Groups = append(rewritten.Groups, user.AllAuthenticated) | ||
| } | ||
| if strings.HasPrefix(g, "system:cluster:") { | ||
| rewritten.Groups = append(rewritten.Groups, g) | ||
| } |
There was a problem hiding this comment.
This is for the globalsa if the feature flag is enabled. Maybe it'd make sense to keep all system: groups?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
See kcp-dev/kcp#3513
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: