-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHC 9.0 compatibility #129
base: master
Are you sure you want to change the base?
Conversation
Now that #130 is merged, this can probably be closed. |
This is a patch to |
2c058b5
to
1dc0700
Compare
@sheaf: The Gods have not heard your prayer, it seems. Is |
Yes, it is relevant to me because I use the constrained traversals that |
I think we would need to create a release branch in order to do this nicely. Is this still important to you @sheaf ? |
Yes, I am still using |
If you can provide a branch I would be happy to rebase the changes in this PR, perhaps with some additional changes to squash the current warnings. I'm not sure which newer commits might need to be backported (if any can be). |
Do the things you need have to be in |
This patch adds GHC 9.0 support relative to
generic-lens-1.2.0.1
.I'm still using this version of
generic-lens
as I make extensive use of constrained traversals, which were removed in the2.0
release.I couldn't find a suitable branch to apply this to, but this patch was done on top of e4f6890.