-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance testing setup to Kedro #4172
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
@ankatiyar , this looks great! I have a short question just for my understanding. How publishing results is happening for the newly created repo: https://github.com/kedro-org/kedro-benchmark-results? I see in your example it's happening every time the results are committed to the main: https://github.com/ankatiyar/benchmark-kedro/blob/c4971ae3d47f26b32dc43b4fe356ed629cc93f19/.github/workflows/publish-benchmark.yml#L6 But in the new repo with the benchmark results the workflow looks different: https://github.com/kedro-org/kedro-benchmark-results/blob/7bd633596c3289ae18a70818099d7ef27b86539f/.github/workfllows/publish-results.yml#L4 Is that on purpose? |
@ElenaKhaustova Thanks for taking a look! Github actions are not currently enabled on |
That totally makes sense, thanks for explaining! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, us usual 🚀
Description
Part of #4128
Development notes
I've managed to set the performance testing framework using
asv
on my fork of Kedro: https://github.com/ankatiyar/kedroThe setup is -
benchmarks/
folder is where the performance/stress tests for various components such asDataCatalog
orOmegaConfigLoader
will go. Right now I've left a dummy test in that we can replace or leave in. I suggest we leave this in so we will know if some regressions in the future are happening because of the runners on Github Actions and not because of our changes.kedro-org
-> https://github.com/kedro-org/kedro-benchmark-results❗ Disclaimer ❗ : This might not immediately work and might require tweaks with permission issues as follow up PRs so I would like to get a first draft in to test the action with the dummy test.
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file