-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move warm-up from session to runner #4262
Merged
Merged
Changes from 13 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7c794f4
Move warm-up to runner
ElenaKhaustova 208a24b
Implemented test for running thread runner with patterns
ElenaKhaustova 7c6729a
Added test for new catalog
ElenaKhaustova 9d5b37d
Add line separator to file
ElenaKhaustova c3229c0
Replaced writing csv manually to writing with pandas
ElenaKhaustova 6c509d9
Merge branch 'main' into fix/4250-move-warm-up-to-runner
ElenaKhaustova bd878c9
Fixed fixture
ElenaKhaustova 68010aa
Removed new catalog from test
ElenaKhaustova 29d373f
Made catalog type a parameter
ElenaKhaustova e90cfd7
Removed old catalog from test
ElenaKhaustova 3f1dbe0
Removed new catalog from test
ElenaKhaustova 892cda4
Removed data creation/loading
ElenaKhaustova e7f2632
Fixed test docstring
ElenaKhaustova 429ca13
Removed extra loop
ElenaKhaustova 3ffd538
Renamed variable for clarifty
ElenaKhaustova 681d3f1
Merge branch 'main' into fix/4250-move-warm-up-to-runner
ElenaKhaustova 01f9b62
Moved warm-up to the top
ElenaKhaustova 069dff4
Moved warm-up to the top
ElenaKhaustova 9d0f579
Merge branch 'main' into fix/4250-move-warm-up-to-runner
ElenaKhaustova 5f6ef85
Updated release notes
ElenaKhaustova b0f9b0f
Merge branch 'main' into fix/4250-move-warm-up-to-runner
ElenaKhaustova e481c72
Remaned variable
ElenaKhaustova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment about this? I also notice this line is duplicated:
registered_ds = [ds for ds in pipeline.datasets() if ds in catalog]
Maybe we can refactor this into one loop so we only loop
pipeline.datasets()
once?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
registered_ds_no_runtime_patterns
is a bit of a mouthful, could we come up with a shorter name? E.g.warm_concrete_ds
(not necessarily the best option, but just an example)?Tbh, I don't mind the two loops - they show the purpose better without too much of a slowdown, but the current refactor is also ok.