Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pyproject.toml on Kedro project template to be compatible with uv, rye, pdm #4263

Open
wants to merge 51 commits into
base: main
Choose a base branch
from

Conversation

lrcouto
Copy link
Contributor

@lrcouto lrcouto commented Oct 28, 2024

Description

Changes the pyproject.toml file on the default project template to work with different package managers.

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@lrcouto lrcouto changed the title Changes to pyproject.toml template Change pyproject.toml on Kedro project template to be compatible with uv, rye, pdm Oct 28, 2024
@lrcouto lrcouto linked an issue Oct 29, 2024 that may be closed by this pull request
@lrcouto lrcouto marked this pull request as ready for review October 29, 2024 02:14
@lrcouto lrcouto closed this Oct 29, 2024
@lrcouto lrcouto reopened this Oct 29, 2024
@lrcouto lrcouto marked this pull request as draft October 29, 2024 03:01
@astrojuanlu
Copy link
Member

(Also don't forget #4116 (comment) !)

Signed-off-by: Laura Couto <[email protected]>
Copy link
Contributor

@ElenaKhaustova ElenaKhaustova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lrcouto and others added 22 commits November 12, 2024 13:53
Signed-off-by: Laura Couto <[email protected]>
Signed-off-by: Laura Couto <[email protected]>
Signed-off-by: Laura Couto <[email protected]>
Signed-off-by: Laura Couto <[email protected]>
Signed-off-by: Laura Couto <[email protected]>
Signed-off-by: Laura Couto <[email protected]>
Signed-off-by: Laura Couto <[email protected]>
Signed-off-by: Laura Couto <[email protected]>
Signed-off-by: Laura Couto <[email protected]>
Signed-off-by: Laura Couto <[email protected]>
Signed-off-by: Laura Couto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default template incompatible with uv, rye, pdm
4 participants