Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kedro Coffee Chat section #4303

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Add Kedro Coffee Chat section #4303

merged 7 commits into from
Nov 7, 2024

Conversation

ElenaKhaustova
Copy link
Contributor

Description

Added a section about coffee chat to the docs as a replacement of the old private page: https://github.com/McK-Internal/kedro-coffee-chat

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
@ElenaKhaustova ElenaKhaustova marked this pull request as ready for review November 6, 2024 15:19
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@noklam
Copy link
Contributor

noklam commented Nov 6, 2024

Maybe Readme is too crowd for this? Would it be better to this section in Wiki and only keep the mention in Readme?

In docs we can add a community section too though we haven't added the slack channel in docs yet.

@ankatiyar
Copy link
Contributor

Agree with @noklam, maybe just the first bit and a link to the announcement channel. The rules and the structure could go in a wiki with upcoming topics and dates too?

@ElenaKhaustova
Copy link
Contributor Author

Added a wiki page as suggested above and updated readme with a reference to it: https://github.com/kedro-org/kedro/wiki/Kedro-Coffee-Chat

Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏾

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ☕

@ElenaKhaustova ElenaKhaustova enabled auto-merge (squash) November 7, 2024 10:14
@ElenaKhaustova ElenaKhaustova merged commit c618000 into main Nov 7, 2024
9 checks passed
@ElenaKhaustova ElenaKhaustova deleted the docs/coffee-chat-page branch November 7, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants