Skip to content

feat: Pagerduty Provider: incident enrichments #4663#4680

Merged
Matvey-Kuk merged 7 commits intokeephq:mainfrom
bbcorp:feature/4663_pagerduty_provider
May 15, 2025
Merged

feat: Pagerduty Provider: incident enrichments #4663#4680
Matvey-Kuk merged 7 commits intokeephq:mainfrom
bbcorp:feature/4663_pagerduty_provider

Conversation

@bbcorp
Copy link
Copy Markdown
Contributor

@bbcorp bbcorp commented May 2, 2025 •
edited
Loading

Closes #4663

📑 Description

PagerDuty Provider: Add useful metadata via enrichment

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

For the future: maybe add a parameter in the provider to add this enrichment.
For all provider in fact.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 2, 2025

Someone is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 2, 2025
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 2, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot Bot added Feature A new feature Provider Providers related issues labels May 2, 2025
@bbcorp bbcorp changed the title Pagerduty Provider: incident enrichments #4663 feat: Pagerduty Provider: incident enrichments #4663 May 2, 2025
@bbcorp
Copy link
Copy Markdown
Contributor Author

bbcorp commented May 2, 2025

To be tested / validated in dev platform

skynetigor
skynetigor approved these changes May 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@skynetigor skynetigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matvey-Kuk Matvey-Kuk enabled auto-merge (squash) May 6, 2025 09:41
bbcorp added 2 commits May 6, 2025 13:26
@bbcorp
Merge branch 'main' of github.com:keephq/keep into feature/4662_pager…
9ff37e8 
…duty_provider
@bbcorp
Merge branches 'feature/4663_pagerduty_provider' and 'feature/4663_pa…
b21b2ba 
…gerduty_provider' of github.com:bbcorp/keep into feature/4663_pagerduty_provider
@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview May 15, 2025 8:01am

@Matvey-Kuk Matvey-Kuk merged commit 6b4fe7e into keephq:main May 15, 2025
14 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2025

🎊 Fantastic work @bbcorp! Your very first PR to keep has been merged! 🎉🥳

You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌
If you're feeling adventurous, why not dive into another issue and keep contributing? The community would love to see more from you! 🚀

For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! 👩‍💻👨‍💻

@talboren
Copy link
Copy Markdown
Member

talboren commented May 15, 2025

@Matvey-Kuk / @skynetigor was this tested? I don’t believe it is working.

@bbcorp
Copy link
Copy Markdown
Contributor Author

bbcorp commented May 15, 2025

Upon testing on my side it wasn't working as expected no 😢

Matvey-Kuk added a commit that referenced this pull request May 15, 2025
@Matvey-Kuk
Revert "feat: Pagerduty Provider: incident enrichments #4663 (#4680)"
f6402c7 
This reverts commit 6b4fe7e.
@Matvey-Kuk Matvey-Kuk mentioned this pull request May 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skynetigor skynetigor skynetigor approved these changes

Assignees

No one assigned

Labels

Feature A new feature Provider Providers related issues size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[➕ Feature]: PagerDuty Provider - add useful metadata via enrichment

6 participants

@bbcorp @CLAassistant @talboren @skynetigor @Matvey-Kuk @shahargl