Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency neverthrow to v6 #202

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Jan 11, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
neverthrow 5.1.0 -> 6.0.0 age adoption passing confidence

Release Notes

supermacro/neverthrow

v6.0.0: Resolve accidental breaking change with type inference on array types

Compare Source

The combine* family of functions (both sync and async) broke any codebase that called these functions on arrays of varying lengths when the previous release was shipped:

https://github.com/supermacro/neverthrow/releases/tag/v5.1.0

The following fix was implemented to address this issue and ensure that arrays (not just tuples) work with the combine* family of functions.

https://github.com/supermacro/neverthrow/pull/435

Why is this shipped as a MAJOR version change?

Because we are now explicitly depending on TypeScript's variadic tuple types feature, which came out in v4 of TypeScript:

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-0.html#variadic-tuple-types

Acknowledgements

Thank you to @​ghost91- for implementing the fix 🙏


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@height
Copy link

height bot commented Jan 11, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2023

⚠️ No Changeset found

Latest commit: 646668f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@keinsell keinsell closed this Jan 13, 2023
@keinsell keinsell deleted the renovate/neverthrow-6.x branch January 13, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant