Skip to content

Update build.gradle.kts#17416

Draft
NetTruyenOfficial wants to merge 1 commit into
keiyoushi:mainfrom
NetTruyenOfficial:main
Draft

Update build.gradle.kts#17416
NetTruyenOfficial wants to merge 1 commit into
keiyoushi:mainfrom
NetTruyenOfficial:main

Conversation

@NetTruyenOfficial

Copy link
Copy Markdown

Trust me, I'm the admin of this website.
I won't be using "s" anymore in the future.

Checklist:

  • Updated versionCode value in build.gradle.kts
  • Updated baseVersionCode in build.gradle.kts (if updated multisrc theme code)
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Set the contentWarning configuration in build.gradle.kts appropriately
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension
  • This PR is AI-assisted, I have reviewed the changes manually and confirmed they are not slop

Correct the data.
@dragonx943

This comment was marked as spam.


keiyoushi {
name = "NetTruyenS (unoriginal)"
name = "NetTruyen Unofficial"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are so many Vietnamese sources called 'NetTruyen'. You should use 'NetTruyenS' to identify this specific source, or rename the website to something else like 'Bách Truyện' ¯_(ツ)_/¯

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Bách Truyện'

Bark Truyen better

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

This comment was marked as spam.

@Smol-Ame

Smol-Ame commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Marking as a draft

  • Unless your website's name & icon is going to be called "NetTruyen Unofficial", the extension name should at least be "NetTruyen (unoriginal)" to fall in line with copycat sources.
  • You didn't bump the versionCode, as mentioned in the PR checklist (that you falsely acknowledged).

@Smol-Ame
Smol-Ame marked this pull request as draft July 8, 2026 05:01

@AwkwardPeak7 AwkwardPeak7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set id in source {} block to the current source's id; otherwise users will be forced to migrate. you can find current id from the repo index

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants