Add OneReader#17619
Merged
Merged
Conversation
duasmisha-hub
marked this pull request as ready for review
July 15, 2026 07:17
duasmisha-hub
force-pushed
the
codex/add-onereader
branch
from
July 15, 2026 07:22
72ce7fa to
34306bc
Compare
Contributor
please test on mihon. |
Contributor
Author
tested. (working fine) |
Contributor
There was a problem hiding this comment.
use icon generator linked in contributing guide, and follow the style convention. i.e square icon with rounded corners, with solid background
| import okhttp3.Response | ||
|
|
||
| @Source | ||
| abstract class OneReader : HttpSource() { |
Contributor
There was a problem hiding this comment.
please implement KeiSource instead, you also need to set libVersion in build.gradle.kts to 1.6
AwkwardPeak7
requested changes
Jul 17, 2026
| .addQueryParameter("capitulo", number) | ||
| .build() | ||
|
|
||
| url = webUrl.run { "$encodedPath?$encodedQuery" } |
Contributor
There was a problem hiding this comment.
save things in memo too
Comment on lines
+101
to
+114
| manga = if (fetchDetails) { | ||
| client.get(apiUrl("api", "mangas", manga.url)).parseAs<MangaDto>().toSManga(details = true) | ||
| } else { | ||
| manga | ||
| }, | ||
| chapters = if (fetchChapters) { | ||
| client.get(apiUrl("api", "chapters", manga.url)) | ||
| .parseAs<Map<String, ChapterDto>>() | ||
| .entries | ||
| .sortedByDescending { it.key.toDoubleOrNull() ?: Double.NEGATIVE_INFINITY } | ||
| .map { it.value.toSChapter(it.key, baseUrl) } | ||
| } else { | ||
| chapters | ||
| }, |
Contributor
There was a problem hiding this comment.
run both in parallel. (async)
AwkwardPeak7
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17390
Adds the OneReader source with full catalog pagination, latest updates, search, filters, manga details, chapters, and reader pages.
Validation performed:
:src:pt:onereader:spotlessCheck:src:pt:onereader:assembleDebug:src:pt:onereader:assembleReleasetagsfield isnullChecklist:
versionCodevalue inbuild.gradle.ktsbaseVersionCodeinbuild.gradle.kts(if updated multisrc theme code)contentWarningconfiguration inbuild.gradle.ktsappropriatelyidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extension