Skip to content

JComic: update to 1.6#17690

Merged
AwkwardPeak7 merged 2 commits into
keiyoushi:mainfrom
hualiong:jcomic
Jul 18, 2026
Merged

JComic: update to 1.6#17690
AwkwardPeak7 merged 2 commits into
keiyoushi:mainfrom
hualiong:jcomic

Conversation

@hualiong

Copy link
Copy Markdown
Contributor

For this source, implementing HttpSource is more convenient than KeiSource.

Checklist:

  • Updated versionCode value in build.gradle.kts
  • Updated baseVersionCode in build.gradle.kts (if updated multisrc theme code)
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Set the contentWarning configuration in build.gradle.kts appropriately
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension
  • This PR is AI-assisted, I have reviewed the changes manually and confirmed they are not slop

@AwkwardPeak7 AwkwardPeak7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, please implement KeiSource; also same comment for client.get getting headers and .string helpers instead of .jsonPrimitive.content etc

@AwkwardPeak7
AwkwardPeak7 merged commit dfe644b into keiyoushi:main Jul 18, 2026
2 checks passed
@hualiong
hualiong deleted the jcomic branch July 19, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants