Madara 1.6 - #18075
Draft
AwkwardPeak7 wants to merge 44 commits into
Draft
Conversation
vetleledaal
reviewed
Jul 29, 2026
vetleledaal
left a comment
Contributor
There was a problem hiding this comment.
Mostly nitpicks. Abstraction seems a bit off, but I don't have any direct suggestions for that.
Contributor
Author
can you clarify? |
Secozzi
reviewed
Jul 29, 2026
vetleledaal
reviewed
Aug 1, 2026
vetleledaal
left a comment
Contributor
There was a problem hiding this comment.
Abstraction seems a bit off
can you clarify?
I was mostly looking at the business logic differences for the related/genre section. The base class should be the one responsible for that, and each variant on top should just handle the translation between the site's interface and the internal model we use.
Contributor
|
Pushed some changes in 0cbad53 and 5c7815f While doing so I wrote down some notes: Used the following script to get a list of remaining extensions, sorted by LOC: rg -g 'build.gradle.kts' -l 'theme = "madara"' | xargs rg -l 'libVersion = "1.4"' | while read -l f
set d (dirname "$f")
printf '%s\t' "$d"
find "$d" -name '*.kt' -print0 | xargs -0 cat 2>/dev/null | wc -l
end | sort -k2 -nOutputsrc/en/woopread 7
src/en/manhuafastnet 9
src/en/pawmanga 9
src/en/vyvymangaorg 9
src/en/whalemanga 9
src/en/mangagofun 10
src/en/toon18 10
src/tr/turkcemangaokutr 10
src/ar/detectiveconanar 11
src/en/manhwa18org 11
src/tr/araznovel 11
src/tr/hayalistic 11
src/en/manhwaden 12
src/en/toonizy 12
src/es/gremorymangas 12
src/fr/hentaiscantrad 12
src/fr/hentaizone 12
src/fr/pantheonscan 12
src/tr/mangasehri 12
src/tr/yaoibar 12
src/en/shibamanga 13
src/en/toongod 13
src/es/toones 13
src/es/topcomicporno 13
src/es/topcomicpornonet 13
src/id/pornhwa18 13
src/th/catzaa 13
src/tr/kabusmanga 13
src/tr/mangazure 13
src/ar/manga3asq 14
src/ar/mangatuk 14
src/es/mangaromance 14
src/es/marmota 14
src/es/monopolyscan 14
src/es/noblessetranslations 14
src/id/holotoon 14
src/tr/mangawt 14
src/vi/truyenvn 14
src/en/mangadrama 15
src/en/zinmanganet 15
src/fr/scanhentaimenu 15
src/ko/rawdex 15
src/th/doujinza 15
src/tr/asurascanstr 15
src/vi/hentaivnplus 15
src/all/allporncomicsco 16
src/ar/mangaspark 16
src/id/hwago 16
src/id/lumoskomik 17
src/pt/lermangas 17
src/th/mangalc 17
src/pt/minitwoscan 18
src/th/doujinlc 18
src/vi/gantzvn 18
src/es/bibliopanda 19
src/es/codexzero 19
src/fr/toonfr 19
src/pt/covenscan 19
src/pt/mangalivreto 19
src/pt/mangaonline 19
src/tr/webtoonhatti 19
src/es/hadesnofansub 20
src/fr/mangasoriginesfr 20
src/pt/ghostscan 20
src/tr/summertoon 20
src/es/richtoscan 21 # ← I got to here
src/all/manhwaclubnet 22
src/all/manhwadashraw 22
src/en/webtoonxyz 23
src/ar/yonabar 27
src/en/lilymanga 27
src/tr/milasub 27
src/pt/nocturnesummer 28
src/fr/mangahubfr 29
src/tr/niverafansub 29
src/fr/hentaiorigines 30
src/pt/pinkseaunicorn 32
src/en/paritehaber 33
src/en/rosesquadscans 33
src/pt/arthurscan 34
src/en/zazamanga 35
src/pt/hotcabaretscan 35
src/pt/leitordemangas 35
src/tr/mangagezgini 35
src/tr/strayfansub 35
src/pt/cerisescans 37
src/es/doujinshell 38
src/pt/mangasbrasuka 38
src/es/lectormangalat 40
src/pt/amuy 40
src/pt/mugiwarasoficial 40
src/ar/mangalek 41
src/en/frierenonline 43
src/en/novelcrow 43
src/en/rdscans 44
src/es/inmortalscan 45
src/es/infrafandub 46
src/en/aquamanga 48
src/en/hentai4free 48
src/en/mangadass 51
src/en/mangaforfreecom 51
src/pt/acervohentai 54
src/es/haremdekira 57
src/en/isekaiscantop 62
src/pt/inkapk 62
src/en/firescans 63
src/en/setsuscans 63
src/es/catharsisworld 63
src/es/manhuaonline 68
src/es/dragontranslationorg 71
src/en/madaradex 72
src/ar/mangalionz 73
src/en/yakshacomics 74
src/id/yubikiri 74
src/es/taurusfansub 76
src/en/mangablaze 78
src/es/barmanga 81
src/es/begatranslation 81
src/es/mhscans 87
src/en/toonily 91
src/es/ragnarokscanlation 96
src/pt/montetai 97
src/vi/truyentuoitho 99
src/en/gourmetscans 103
src/id/mgkomik 106
src/pt/noindexscan 106
src/th/doodmanga 106
src/es/manhwalatino 108
src/th/manhuakey 110
src/pt/tiamanhwa 111
src/pt/xxxyaoi 115
src/th/manhwabreakup 115
src/th/mangaisekaithai 119
src/th/manhuabug 120
src/th/manhuathai 120
src/pt/fenixproject 123
src/tr/ruyamanganet 125
src/ar/rocksmanga 126
src/es/emperorscan 151
src/pt/littletyrant 151
src/es/templescanesp 161
src/pt/huntersscans 169
src/all/manhwa18cc 199
src/es/mangasnosekai 229
src/es/mangacrab 265
src/zh/bakamh 288
src/en/kunmangaonline 333
src/en/hentairead 343
src/en/mangadistrict 413
src/vi/hentaicube 421
src/en/manga18fx 632
src/all/manhuarm 1415 |
xMohnad
reviewed
Aug 16, 2026
…q/Manga3asq.kt `chapter-release-date` contains the view count along with the date, which causes parsing to fail. Co-authored-by: Mohannad <134175138+xMohnad@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened for initial review of the actual theme.
Opted to store wordpress post id as stable unique global id for manga and slug/path saved in memo. There is compatibility for old library entries, so migration isn't strictly needed.
There are now two variants:
madara_load_more/manga/ajax variant is more feature rich in terms of filters and stuff
non ajax is limited. It intentionally doesn't support complex filters via madara search page because there is no way to get post id there, without making call to each manga.
mainly review the first commit only.
untested sources (for now):
Checklist:
versionCodevalue inbuild.gradle.ktsbaseVersionCodeinbuild.gradle.kts(if updated multisrc theme code)contentWarningconfiguration inbuild.gradle.ktsappropriatelyidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extension