ClipStudioReader: extlib 1.6 - #18134
Open
furaibo9714 wants to merge 2 commits into
Open
Conversation
AwkwardPeak7
reviewed
Aug 2, 2026
|
|
||
| override fun headersBuilder() = super.headersBuilder() | ||
| .set("Referer", "$baseUrl/") | ||
| override fun Headers.Builder.configureHeaders() = add("Referer", "$baseUrl/") |
Contributor
There was a problem hiding this comment.
referer is added by default
| // EPUB-based path | ||
| val tokenUrl = "$baseUrl/api/tokens/viewer?content_id=$contentId".toHttpUrl() | ||
| val tokenResponse = client.newCall(GET(tokenUrl, headers)).execute() | ||
| val tokenResponse = client.get(tokenUrl, headers) |
Contributor
There was a problem hiding this comment.
headers are passed implicitly, no need to pass them yourself
|
|
||
| val faceResponse = client.newCall(GET(faceUrl, headers)).execute() | ||
| val faceResponse = client.get(faceUrl, headers) | ||
| if (!faceResponse.isSuccessful) throw Exception("HTTP error ${faceResponse.code} while fetching face.xml") |
Contributor
There was a problem hiding this comment.
client.get ensures http success
|
|
||
| private val domain = baseUrl.toHttpUrl().host | ||
| private val preferences by getPreferencesLazy() | ||
| private val rscHeaders = headersBuilder() |
Contributor
There was a problem hiding this comment.
Suggested change
| private val rscHeaders = headersBuilder() | |
| private val rscHeaders get() = headersBuilder() |
|
|
||
| override val supportsLatest = true | ||
|
|
||
| private val domain = baseUrl.toHttpUrl().host |
Contributor
There was a problem hiding this comment.
Suggested change
| private val domain = baseUrl.toHttpUrl().host | |
| private val domain get() = baseUrl.toHttpUrl().host |
Comment on lines
+38
to
+39
| addInterceptor(Deobfuscator()) | ||
| addInterceptor(ImageInterceptor()) |
Contributor
There was a problem hiding this comment.
call super.configureClient instead
| status = if (statusText.contains("完結")) SManga.COMPLETED else SManga.ONGOING | ||
| val hideLocked = preferences.getBoolean(HIDE_LOCKED_PREF_KEY, false) | ||
|
|
||
| val sManga = if (fetchDetails) { |
Contributor
There was a problem hiding this comment.
you have all the info already, return both unconditionally
| } | ||
|
|
||
| override fun getFilterList(): FilterList = FilterList( | ||
| override fun getFilterList(data: kotlinx.serialization.json.JsonElement?): FilterList = FilterList( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
versionCodevalue inbuild.gradle.ktsbaseVersionCodeinbuild.gradle.kts(if updated multisrc theme code)contentWarningconfiguration inbuild.gradle.ktsappropriatelyidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extension