Skip to content

Mangadotnet[EN]: Fix Search - #18471

Open
Arkai1 wants to merge 9 commits into
keiyoushi:mainfrom
Arkai1:Dot
Open

Mangadotnet[EN]: Fix Search#18471
Arkai1 wants to merge 9 commits into
keiyoushi:mainfrom
Arkai1:Dot

Conversation

@Arkai1

@Arkai1 Arkai1 commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Checklist:

  • Updated versionCode value in build.gradle.kts
  • Updated baseVersionCode in build.gradle.kts (if updated multisrc theme code)
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Set the contentWarning configuration in build.gradle.kts appropriately
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension
  • This PR is AI-assisted, I have reviewed the changes manually and confirmed they are not slop

Closes #18457

AwkwardPeak7
AwkwardPeak7 reviewed Aug 17, 2026
View reviewed changes
Comment thread src/en/mangadotnet/src/eu/kanade/tachiyomi/extension/en/mangadotnet/Mangadotnet.kt Outdated
Comment thread src/en/mangadotnet/src/eu/kanade/tachiyomi/extension/en/mangadotnet/Mangadotnet.kt Outdated
Comment thread src/en/mangadotnet/src/eu/kanade/tachiyomi/extension/en/mangadotnet/Mangadotnet.kt Outdated
@Arkai1

Arkai1 commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

I have applied the suggestions you asked and it failed tasks, Currently gitHub web is having issue. I will check it later when Github becomes stable.

@Arkai1
Null Cleanup
004785e 
Forget to remove null call in line 304 which caused the lint error, now it should be fixed.
@Alpha-782

Alpha-782 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Search pagination does not work, if that was missed while testing.

@Arkai1

Arkai1 commented Aug 18, 2026

Copy link
Copy Markdown
Author

Search pagination does not work, if that was missed while testing.

Ok got it, Looks like it only loads the first 28 entries and then the loading spinner spins forever will check it.

Arkai1 added 2 commits August 18, 2026 13:33
@Arkai1
Fix pagination issue
9a9778d 
Switched to /api/search from Search.data, It gives simple JSON response which is easy to process.

Previously RCS decoder used to fail silently which caused the issue infinite loading spinner.
@Arkai1
Merge branch 'keiyoushi:main' into Dot
218600f
@Arkai1
Arkai1 requested a review from AwkwardPeak7 August 18, 2026 08:09
@AwkwardPeak7

AwkwardPeak7 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

did you test this?
seems like api requires cursor instead of page number

@Arkai1

Arkai1 commented Aug 18, 2026

Copy link
Copy Markdown
Author

did you test this? seems like api requires cursor instead of page number

Yup tested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AwkwardPeak7 AwkwardPeak7 Awaiting requested review from AwkwardPeak7

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mangadot.net - Filter search no longer working

3 participants

@Arkai1 @Alpha-782 @AwkwardPeak7