Add dockerfile#31
Open
yarray wants to merge 1 commit into
Open
Conversation
|
Great work, but a suggestion for a slightly more efficient Dockerfile. And i suggest using port 8000 instead of 443, since 443 is restricted on linux systems. and a docker-compose file to go along with it. |
|
Great work! I will test it locally soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dockerfile and modify documentation along with testing script accordingly. Note when ENV=docker, test-installation.sh will not check the existence of the model file to avoid error.