fix(rate_limit): replace HeaderValue unwrap with infallible int_heade…#684
Open
Olisachukwuma1 wants to merge 2 commits into
Open
fix(rate_limit): replace HeaderValue unwrap with infallible int_heade…#684Olisachukwuma1 wants to merge 2 commits into
Olisachukwuma1 wants to merge 2 commits into
Conversation
…r helper All 5 unwrap() calls on HeaderValue::from_str were converting i64::to_string() values, which only produce ASCII digits and are always valid header values. Extracted int_header() helper that documents the invariant and uses unwrap_or_else as a safe fallback instead of bare unwrap. Closes issues: rate_limit.rs panic-prone calls audit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #633
closes #634
closes #635
closes #636
…r helper
All 5 unwrap() calls on HeaderValue::from_str were converting i64::to_string() values, which only produce ASCII digits and are always valid header values. Extracted int_header() helper that documents the invariant and uses unwrap_or_else as a safe fallback instead of bare unwrap.
Closes issues: rate_limit.rs panic-prone calls audit