Feature/updates 2026 06 29#690
Open
Zarmaijemimah wants to merge 4 commits into
Open
Conversation
added 4 commits
June 29, 2026 13:56
…n tests - Replace unwrap/expect with typed error propagation in get_test_pool() - Document test invariants with clear expect() messages - Add graceful degradation for database connection failures - Preserve observability with descriptive panic messages - All 7 panic-prone calls addressed per acceptance criteria
- Replace unwrap() with expect() and descriptive error messages - Add assertion messages for better test failure context - Improve error observability in test failures - All 8 panic-prone calls now have proper error handling
- Replace all 8 unwrap() calls with documented panic helper - Add compile_pattern() function with clear error messages - Document intentional panics for hardcoded regex patterns - Add PatternError type for future error handling flexibility - Add test to verify all patterns compile successfully - Add test to demonstrate panic behavior for invalid patterns All regex patterns are constants verified at development time. If compilation fails, it indicates a programming error that must be fixed before deployment. Resolves: panic-prone calls in src/masking/patterns.rs
Contributor
Author
|
close #637 |
|
@Zarmaijemimah Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #637
Feature/updates 2026 06 29