Feature/updates 2026 06 30#691
Merged
kelly-musk merged 3 commits intoJul 3, 2026
Merged
Conversation
added 2 commits
June 29, 2026 15:31
- Replaced all 15 unwrap() calls with expect() containing descriptive error messages - Each expect() explains the failure context and root cause - All changes are in test code only (tests/alerting_integration.rs) - Errors indicate unrecoverable test setup failures (registry conflicts, serialization errors) - No production code affected - Added ALERTING_TESTS_PANIC_FIX.md documenting all changes Fixes panic-prone calls in metric registration helpers and render function. Maintains test isolation and existing test structure.
- Replaced all 40+ unwrap() calls with expect() containing descriptive error messages - Fixed panic-prone calls in seed_fee_structures() database setup (5 instances) - Fixed panic-prone calls in all 8 test functions - Each expect() explains the failure context (HTTP request building, service calls, JSON parsing, etc.) - Errors indicate specific failure points for easier debugging - Test code only - no production code affected Improves test reliability and debugging experience with clear error messages.
Contributor
Author
|
close #606 |
|
@Zarmaijemimah Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #606
Feature/updates 2026 06 30