fix(tests): reduce panic-prone calls in wallet_analytics_test.rs#700
Open
paul-itodo wants to merge 1 commit into
Open
fix(tests): reduce panic-prone calls in wallet_analytics_test.rs#700paul-itodo wants to merge 1 commit into
paul-itodo wants to merge 1 commit into
Conversation
…lymusk#567) Replace all bare .unwrap() calls with .expect("message") to add observability context on test failure. The double-unwrap pattern (assert is_some then unwrap) is replaced with a single expect that names the invariant being asserted. DB connection setup retains its expect since the test cannot proceed without a live database. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/wallet_analytics_test.rsfrom upstream and land it in this fork (file was missing from the fork's master).unwrap()calls with.expect("message")to add observability context on failureassert!(x.is_some()); x.unwrap()) to a single.expect()that names the asserted invariantChanges
tests/wallet_analytics_test.rs(new): full integration test suite for wallet analytics with typed failure messages on every fallible callAcceptance criteria met
expectmessagesexpect(unrecoverable if no test DB available)Closes #567
Test plan
cargo test --test wallet_analytics_test -- --ignoredagainst a running test databaseunwrap()on aNonevalue")🤖 Generated with Claude Code