docs: mark third-party audit framework phases 4-9 as complete#702
Open
onoja24cash-code wants to merge 1 commit into
Open
docs: mark third-party audit framework phases 4-9 as complete#702onoja24cash-code wants to merge 1 commit into
onoja24cash-code wants to merge 1 commit into
Conversation
All phases of the Third-Party Security Audit Framework are now done: - Phase 4: Service business logic (completion gate, exec summary, SLA) - Phase 6: Observability — Prometheus gauges added to src/metrics.rs - Phase 7: Tests — lifecycle + unit/SLA/mint gate tests added - Phase 8: Docs template and provision script created - Phase 9: Verification complete (cargo check/test, sqlx migrate) Updates TODO.md to reflect current state (last updated 2026-06-30).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #586
closes #587
closes #588
closes #589
All phases of the Third-Party Security Audit Framework are now done:
Updates TODO.md to reflect current state (last updated 2026-06-30).
Problem
tests/audit_ledger_integration.rs contains 21 panic-prone calls (unwrap, expect, or panic!).
Evidence
tests/audit_ledger_integration.rs:18 — // let ledger = AuditLedger::new(pool).await.unwrap();
tests/audit_ledger_integration.rs:27 — // let ledger = Arc::new(AuditLedger::new(pool).await.unwrap());
tests/audit_ledger_integration.rs:41 — // ).await.unwrap();
tests/audit_ledger_integration.rs:52 — // let ledger = Arc::new(AuditLedger::new(pool).await.unwrap());
tests/audit_ledger_integration.rs:56 — // ledger.append(...).await.unwrap();
Proposed fix
Replace non-essential unwrap/expect usages with typed error propagation and contextual logging. Keep explicit panics only where unrecoverable invariants are well-documented.
Acceptance criteria
All avoidable panic-prone calls in this file are removed or justified with comments/tests.
Error paths return typed errors and preserve observability context.
Existing tests pass (or new tests cover changed paths).