feat(ux): add skeleton loading states to balance cards and transactio…#338
Open
ruthoreaji-123 wants to merge 1 commit into
Open
feat(ux): add skeleton loading states to balance cards and transactio…#338ruthoreaji-123 wants to merge 1 commit into
ruthoreaji-123 wants to merge 1 commit into
Conversation
…n history - Added loading prop to BalanceCard component with skeleton placeholders - Added loading prop to TransactionHistory component with skeleton rows - Added loading prop to WalletInfo component with skeleton layout - Updated dashboard-content.tsx to pass loading state to all components - eth-price-ticker.tsx already had skeleton loading (no changes needed) - Reduces layout shift and improves UX during data fetching - Addresses issue kellymusk#321: New contributors can now see proper loading states Closes kellymusk#321
|
@ruthoreaji-123 is attempting to deploy a commit to the kelly musk's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@ruthoreaji-123 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
@kelly-musk please kindly review. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #321 by adding skeleton loading states to balance cards and transaction history, reducing layout shift and improving the user experience during data fetching.
Changes Made
Added Skeleton Loading States
loadingprop with skeleton placeholders for token symbol, amount, and USD valueloadingprop with 5 skeleton rows matching transaction list layoutloadingprop with skeleton for wallet icon, name, and addressloadingstate to all child componentsImpact
Closes #321