feat: add confirmation dialog before submitting onramp/offramp orders (closes #327)#340
Open
Creative-Titilayo wants to merge 1 commit into
Conversation
Both the onramp and offramp flows previously created an order on a single button click, with no final review step. This adds a confirmation dialog as the last step before calling the create-order API. The dialog surfaces, per the requirements in kellymusk#327: - exact amount sending / receiving - exchange rate applied and its expiry (rate countdown / rate-lock) - processing and network fees - estimated completion time - destination wallet address (onramp) / bank account note (offramp) The calculator submit now opens the dialog (handleInitialSubmit); the order is only created after the user explicitly clicks "Confirm and Pay". Closes kellymusk#327 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@Creative-Titilayo is attempting to deploy a commit to the kelly musk's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Creative-Titilayo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a transaction confirmation dialog as the final step before submitting onramp and offramp orders. Previously both flows created an order on a single button click, with no final summary or explicit confirmation. The calculator's submit now opens a review dialog, and the create-order API is only called after the user clicks "Confirm and Pay" — preventing accidental orders and meeting financial-UX standards.
Related Issue
Closes #327
Changes
🪟 Onramp Confirmation Dialog
components/onramp/onramp-page-client.tsxshowConfirmDialogstate and ahandleInitialSubmithandler that opens the dialog instead of submitting directly.onSubmittohandleInitialSubmit; the existinghandleSubmit(create-order) now only runs from the dialog's "Confirm and Pay" button.🪟 Offramp Confirmation Dialog
components/offramp/offramp-page-client.tsxshowConfirmDialogstate and ahandleInitialSubmithandler that opens the dialog instead of submitting directly.onSubmittohandleInitialSubmit; the existinghandleSubmit(create-order) now only runs from the dialog's "Confirm and Pay" button.DialogandButtonUI primitives.Verification Results