Skip to content

Commit

Permalink
add Docker support
Browse files Browse the repository at this point in the history
  • Loading branch information
@kelseyhightower
kelseyhightower committed Feb 7, 2018
1 parent 80f38e0 commit ed6c73f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Dockerfile
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
FROM scratch

This comment has been minimized.

Sign in to view

Copy link
@PassTheMayo

PassTheMayo Oct 23, 2018

no-SQL? :mmLol:

This comment has been minimized.

Sign in to view

Copy link
@lera2od

lera2od Feb 22, 2024

i had this problem thank you for fixing this

11 comments on commit ed6c73f

@taiidani
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! Fixes #18 just like #19 does! 🎉

@crozone
Copy link

@crozone crozone commented on ed6c73f Feb 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given Docker's reputation, I'm pretty sure this opens at least 5 root escalation vulnerabilities. Please consider reverting.

@nylen
Copy link

@nylen nylen commented on ed6c73f Feb 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm.... this looks like code. 😞

@SirNeuman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be open to creating a pull request to revert this change if there's enough support. Might take me a bit to get around to doing it (I have to make sure it doesn't have any repercussions on the rest of the codebase, which shouldn't be too hard given the current 100% test coverage), but I would love to contribute.

@nylen
Copy link

@nylen nylen commented on ed6c73f Feb 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#773

@ryanhelms
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have too much time on your hands, lol. 🔢

@tommasoresti
Copy link

@tommasoresti tommasoresti commented on ed6c73f Mar 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FROM is highlighted 😱it smells like code

@willsheppard
Copy link

@willsheppard willsheppard commented on ed6c73f Feb 6, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm.... this looks like code. 😞

I can confirm this file contains no code, it's a no-op: https://hub.docker.com/_/scratch

@AlwaysExtraordinary
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

给我整哲学呢？

@1770577032
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因吹撕停

@cloudypan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

前来学习

Please sign in to comment.