You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Scheduled Synctech SMS Drive syncs now use the daemon's already-open store when run from serve.
Drive polls create one outer source-level sync_runs row, including zero-selected polls, and fail that run on list/checksum/stability/download/import/checkpoint errors.
Drive imports now import backup files into the existing source lifecycle instead of creating nested sync runs per downloaded backup.
Successful Drive polls update checkpoint counts, touch sources.last_sync_at, and recompute conversation stats when files import.
Scheduled cache rebuild logic is shared by Gmail/IMAP and configured Synctech syncs.
Why
This keeps scheduled Drive sync lifecycle state accurate and avoids duplicate stores/runs that can obscure failures or freshness.
Impact
Configured Drive sync status, freshness, and analytics cache updates should now reflect every poll, including no-op polls and failed polls.
Validation
go test -tags "fts5 sqlite_vec" ./cmd/msgvault/cmd ./internal/synctechsms ./internal/store
Summary verdict: one medium correctness issue should be addressed before merge.
Medium
cmd/msgvault/cmd/add_synctech_sms_drive.go:213 — If one Drive backup imports successfully and a later selected backup fails, the function returns before RecomputeConversationStats runs. The successful file is already marked imported, so future retries may skip it and leave denormalized conversation stats stale indefinitely.
Suggested fix: Recompute stats after each successful file import, or defer a recompute whenever any records/files were imported before returning an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
serve.sync_runsrow, including zero-selected polls, and fail that run on list/checksum/stability/download/import/checkpoint errors.sources.last_sync_at, and recompute conversation stats when files import.Why
This keeps scheduled Drive sync lifecycle state accurate and avoids duplicate stores/runs that can obscure failures or freshness.
Impact
Configured Drive sync status, freshness, and analytics cache updates should now reflect every poll, including no-op polls and failed polls.
Validation
go test -tags "fts5 sqlite_vec" ./cmd/msgvault/cmd ./internal/synctechsms ./internal/storemake testify-helper-checkgo vet -tags "fts5 sqlite_vec" ./...