Add pagination to acitities feed#9
Open
adammck wants to merge 2 commits into
Open
Conversation
This adds :next_page and :previous_page methods to FitnessActitiesFeed, which return new instances. The existing :next and :previous accessors work as before, although they're not very useful now that pagination is available. For example, to fetch every item ever posted: feed = @user.fitness_activities items = [] while feed items += feed.items feed = feed.next_page end This would obviously be a very bad idea in production.
naveed-ahmad
pushed a commit
to naveed-ahmad/health_graph
that referenced
this pull request
Nov 3, 2015
Switch to markdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
:next_pageand:previous_pagemethods toFitnessActitiesFeed, which return new instances of the same class. The existing:nextand:previousaccessors work as before, although they're not very useful now that pagination is available.For example, to fetch every item ever posted:
(This would obviously be a very bad idea in production)
This involved a minor refactoring of the test fixtures. Hope you don't mind.
/cc @andrewpbrett