feat: Add rMQR Code encoder #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorairolake
force-pushed
the
feature/rmqr-code
branch
2 times, most recently
from
844d0f0 to
37f2fe2
Compare
|
I added the license information for this crate and the |
sorairolake
force-pushed
the
feature/rmqr-code
branch
from
37f2fe2 to
98e15e1
Compare
sorairolake
force-pushed
the
feature/rmqr-code
branch
from
98e15e1 to
f208735
Compare
sorairolake
force-pushed
the
feature/rmqr-code
branch
from
f208735 to
875b85c
Compare
This implementation is based on the [`qrqrpar`](https://crates.io/crates/qrqrpar) crate.
sorairolake
force-pushed
the
feature/rmqr-code
branch
from
875b85c to
2bfcae9
Compare
|
@kennytm Could you review this pull request? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a rMQR Code (Rectangular Micro QR Code) encoder to this crate. It's standardized as ISO/IEC 23941.
This implementation is based on the
qrqrparcrate, which is a fork of this crate. It's licensed under the BSD 3-Clause "New" or "Revised" License, so I think it's possible to import the code from theqrqrparcrate into this crate.The shape of rMQR Code is rectangular, not square. So I changed
Renderer::newto take the vertical modules count in addition to the horizontal modules count.1 This is a breaking change.Note
The feature to automatically choice the rMQR code version implemented in the
qrqrparcrate is not implemented. This is because I didn't think it is necessary to add it. If you think it is necessary, I think you can implement it usingbits::encode_auto_rmqras a reference.Closes #80
Footnotes
Except for rMQR code, the horizontal modules count and the vertical modules count should be the same value. ↩