Update tools to more gracefully handle errors

[matthew-rosen-12]

Update estimates tools to gracefully handle errors
Use PostResponse consistently
raise responses for status if the response does not include an errors field (all GET responses except estimates)

[matthew-rosen-12]

I created a separate EstimatesResp model instead of using PostResponse[Estimates] because the estimates response should only contain a single result. I thought it was fine to get rid of the result key

[matthew-rosen-12]

I think this can be replaced by PostResponse[Statements] since errors exists as an attribute on PostResponse[Statements] until serialization

[matthew-rosen-12]

I did QA for the tools locally. The tools work as expected, except that for the below tools, identifiers without data get mapped to empty data in results:
get_company_description_from_identifiers
get_competitors_from_identifiers
get_earnings_from_identifiers
get_rounds_of_funding_from_identifiers
get_funding_summary_from_identifiers

For example, the get_company_description_from_identifiers tool returns:
{"results":{"COMPANY_WITH_NO_DATA":""}}

whereas the get_consensus_target_price_from_identifiers tool returns:
{"results":{},"errors":["COMPANY_WITH_NO_DATA: No results found."]}

We could change the corresponding APIs to raise 404 errors if no data was found in order to change those empty data-mappings to an error; no additional changes to the client would be needed.

[srisi-kensho]

these two functions get defined a few times.

Could we handle them with generics? Something like

  class SingleResultResp(BaseModel, Generic[T]):
      """Base response model that unwraps a single result from the API's multi-result format."""

      result: T | None = None
      error: str | None = None

and

class EstimatesResp(SingleResultResp[Estimates]):

Or was one of the goals of the PR to reduce the usage of PostResponse?

[matthew-rosen-12]

Yeah I will update to handle with generics. I wasn't sure if I should abstract out a class like that since the Estimates endpoints are the only endpoints (and will continue to be the only endpoints?) that return a single response in the results / errors format

[matthew-rosen-12]

updated