Skip to content

Make MergerConsideration optional #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michellekeoy merged 1 commit into from
Mar 25, 2026
Merged

Make MergerConsideration optional #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions kfinance/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## v5.1.1
- Change MergerInfo consideration to Optional

## v5.1.0
- Add target price and analyst recommendation tools

Expand Down
2 changes: 1 addition & 1 deletion kfinance/client/kfinance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1481,7 +1481,7 @@ def get_participants(self) -> dict:
}

@property
def get_consideration(self) -> MergerConsideration:
def get_consideration(self) -> MergerConsideration | None:
"""A merger's consideration is the assets exchanged for the target company.

Properties in the consideration include:
Expand Down
2 changes: 1 addition & 1 deletion kfinance/domains/mergers_and_acquisitions/merger_and_acquisition_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,4 @@ class MergerConsideration(BaseModel):
class MergerInfo(BaseModel):
timeline: list[MergerTimelineElement]
participants: MergerParticipants
consideration: MergerConsideration
consideration: MergerConsideration | None = None
Loading