Fix: wait for animate bug #3958
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that when multiple animations are triggered in a row, only the last callback is executed. Closes kenwheeler#607 kenwheeler#1737 kenwheeler#2401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
waitForAnimateis set tofalse, if you trigger multiple consecutive navigations, you see a glitch at the end of the animation (the CSS transition is cleared by the first animation callback, while the last animation is still running).This makes sure that only the last callback is executed.
Without fix:
http://jsfiddle.net/xidi2xidi/yzn9v5ej/6/
With fix:
http://jsfiddle.net/xidi2xidi/xkwgjd8e/1/
Closes #607 #1737 #2401