Sieve of Eratosthenes optimization. #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complexity and space reduced to a half.
|
The code gives wrong output for input- 0 and 1 |
ankit167
reviewed
May 26, 2017
math/primes_sieve_of_eratosthenes.py
Outdated
| assert(x >= 0) | ||
| # If x is even, exclude x from list (-1): | ||
| sieve_size = (x//2 - 1) if x % 2 == 0 else (x//2) | ||
| sieve = [1 for v in range(sieve_size)] # Sieve |
There was a problem hiding this comment.
Atleast two spaces before inline comment.
ankit167
reviewed
May 26, 2017
math/primes_sieve_of_eratosthenes.py
Outdated
| # If x is even, exclude x from list (-1): | ||
| sieve_size = (x//2 - 1) if x % 2 == 0 else (x//2) | ||
| sieve = [1 for v in range(sieve_size)] # Sieve | ||
| primes = [2] # List of Primes |
There was a problem hiding this comment.
Atleast two spaces before inline comment.
ankit167
reviewed
May 26, 2017
math/primes_sieve_of_eratosthenes.py
Outdated
| if sieve[i] == 1: | ||
| value_at_i = i*2 + 3 | ||
| primes.append(value_at_i) | ||
| for j in range(i, sieve_size, value_at_i): | ||
| sieve[j]=0 |
There was a problem hiding this comment.
missing white spaces around operator
Now return []
|
Fixed error for input, spaces before comment and operator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complexity and space reduced to a half.