-
Notifications
You must be signed in to change notification settings - Fork 251
fix: Enhanced announcement bar UI (light & dark mode improvement) #722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and congratulations 🎉 for opening your very first pull request in keploy
Achanandhi-M
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Charul192, thanks for raising the PR. For the announcement bar, we are looking to use a light orange background. Could you please update it to a lighter shade of orange?
1866dfc to
79268cb
Compare
|
Hi @Achanandhi-M,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Charul192,
We need the default light orange background color. Could you please update it throughout the full design? Also please fix the DCO and prettify issues
Hey @Achanandhi-M, |
Achanandhi-M
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Charul192 Still the pipelines are failing, can you please fix it, don't try to fix the vale linter issues, try to fix the other pipeline issues, also in your PR why there are 61 files are changed?
Signed-off-by: Charul <[email protected]>
63193a5 to
bb94387
Compare
|
Hey @Achanandhi-M, |




What has changed?
This PR Resolves #3002
Type of change
How Has This Been Tested?
💻 Desktop (Light + Dark Mode)
📱 Mobile (Chrome DevTools responsive view)
Light Mode:
Checklist: