Fixed Issuesssss #83
Open
Fixed Issuesssss #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ayaan286 <[email protected]>
Ayaan286
force-pushed
the
ayaan-fellow-branch
branch
from
42f42f7 to
6b54934
Compare
|
Hey @Ayaan286, Thank you for raising the pr! Unfortunately we can`t merge this pr. As this was the part of API fellowship assignment, we are really proud of your work. Looking to see your more contribution in future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Issues Fixed in samples-typescript:
✅ Critical Security Issues Fixed:
SQL Injection Vulnerabilities in ts-nhost/src/controllers/todoController.ts:
Fixed string interpolation in GraphQL mutations
Replaced with proper GraphQL variables
Added input validation for all parameters
SQL Injection Vulnerabilities in ts-nhost/src/controllers/userController.ts:
Fixed string interpolation in deleteUser mutation
Added comprehensive input validation
Improved data sanitization
Missing Database Connection in express-mongodb/server.js:
Added MongoDB connection call
Ensured database is connected on server start
✅ Dependency Issues Fixed:
Missing Type Definitions in ts-nhost/package.json:
Added @types/dotenv for proper TypeScript support
All other type definitions were already present
Improved CORS Configuration in node-jwt/app.js:
Added environment variable support for CORS origin
Added credentials and optionsSuccessStatus for better security