Skip to content

script for converting retinanet weights from trochvision #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

script for converting retinanet weights from trochvision #2233

wants to merge 2 commits into from
+292 −13

Conversation

sineeli
Copy link
Collaborator

@sineeli sineeli commented Apr 27, 2025

Create a script for converting following torchvison retinanet model checkpoint to keras-hub.

  1. retinanet_resnet50_fpn_coco
  2. retinanet_resnet50_fpn_v2_coco

mattdangerw
mattdangerw approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one question.

keras_hub/src/models/retinanet/retinanet_image_converter.py
*args,
**kwargs,
):
# TODO: update presets and remove these old config options. They were
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we already updated the preset files? We don't need these shims anymore?

Copy link
Collaborator Author

@sineeli sineeli Apr 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, but with this we can update the files, I will do that. Yes we will not the extra params

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably good practice to ditch this change from this PR then. And add this change to the upcoming PR that updates the presets.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the presets as well as script is ready and I already generated presets just the uploading to Kaggle is pending

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I'll just wait for the preset update on this PR then, either way fine. (but let's avoid removing the compat hack before we add the new presets)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdangerw mattdangerw mattdangerw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sineeli @mattdangerw